Add keyboard navigation to search #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lfrancke
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Thank you for the docs. I tried it locally and it worked.
For the record: I saw it fail a few times but could not reproduce. I looked at the source code as well and don't think it should make anything worse. Therefore I believe this is good to go even though it could be improved later.
Two things I'd love to improve at some point (I talked to Xenia about this)
- Pressing up/down in the search box now moves to the beginning/end of the edit box and I'd love it if it could instead move to the first/last serch result
- Only the "link" is highlighted in the search results. It'd be nice if we could highlight the entire "cell"
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/documentation#616
This PR adds the following navigation shortcuts to the search:
Enteris pressed -> Focus first search resultUpandDownarrow keys when search result in focus (the focus is basically on the link within the search result)Enterto open link in same tabShift + Enterto open link in a new windowStrg + Enterto open link in a new tab of the same window/to get the search input field into focus againNot an Javascript expert, so would be nice if someone could test the implementation and give some feedback if needed. Wrote a short Nuclino article on how I developed locally and how it can be tested: https://app.nuclino.com/Stackable/Engineering/Developing-with-Search-locally-bb51c5c1-d0e5-478f-8c3c-d6d64fd8d895